Hi, developers!
As discuss with @bb7133 @XuHuaiyu @BusyJay @tison and other contributors, we agree on that important variables and config files should be reviewed by domain experts to ensure the quality and compatibility.
TiDB
For TiDB, the following files are issued:
- https://github.com/pingcap/tidb/blob/master/sessionctx/variable/
- https://github.com/pingcap/tidb/blob/master/config/config.toml.example
changes on the file or directory should be reviewed by anyone of:
TiKV
For TiKV, the following files are issued:
- tests/integrations/config/test-custom.toml
- etc/config-template.toml
- components/cdc/src/config.rs
- components/batch-system/src/config.rs
- components/pd_client/src/config.rs
- components/sst_importer/src/config.rs
- components/raftstore/src/store/worker/split_config.rs
- components/raftstore/src/coprocessor/config.rs
- components/encryption/src/config.rs
- src/coprocessor_v2/config.rs
- src/storage/config.rs
- src/server/gc_worker/config.rs
- src/server/lock_manager/config.rs
- src/server/config.rs
- src/config.rs
changes on these files should be reviewed by @BusyJay.
In order to add the rules in review PR, we plan to add the review required bot in pingcap/tidb and tikv/tikv repos.