Proposal: Use "gh pr checkout" to replace checkout-pr-branch.sh

Hi, as we already have gh pr checkout here, maybe we can remove the checkout-pr-branch.sh in tidb?

Benefits

More simple

gh pr checkout <pr number> vs checkout-pr-branch.sh <username>:<pr branch>

Actively maintained

gh is developed by github at https://github.com/cli/cli, providing nearly all platform support.

2 Likes

Yes of course. Actually I do as you describe, and tend to remove that script since I guess there is no user for it.

Implemented in https://github.com/pingcap/tidb/pull/28900

After parser been merged into TiDB, there is also an outdated parser/checkout-pr-branch.sh could be removed.

1 Like